Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jest to dev dependencies #66

Open
kerimhudson opened this issue Aug 10, 2021 · 0 comments
Open

Move jest to dev dependencies #66

kerimhudson opened this issue Aug 10, 2021 · 0 comments

Comments

@kerimhudson
Copy link

kerimhudson commented Aug 10, 2021

Describe the bug
A clear and concise description of what the bug is.

Jest is installed as a dependency, not a dev dependency. This caused us some issues regarding module resolutions (specifically with Prisma and Decimal.js), throwing typescript errors due to the differences between latest version of Decimal.js (10.3.1) and the version used by Jest (10.2.0).

To Reproduce

Please provide a codesandbox of your issue or I will not be able to diagnose and fix it.

Install Decimal.js and this package in the same repo. Decimal.js typings will be that of the version in jest (10.2.0), and not the latest (10.3.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant