Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser hangs up when I click Response tab #41

Closed
azyobuzin opened this issue Aug 17, 2020 · 2 comments
Closed

Browser hangs up when I click Response tab #41

azyobuzin opened this issue Aug 17, 2020 · 2 comments
Assignees
Labels
area-Frontend bug Something isn't working

Comments

@azyobuzin
Copy link
Contributor

azyobuzin commented Aug 17, 2020

How to repro

The issue occurs when I open Response tab of a request whose response is big (about 76KB). The format of the response is JSON and the content-type header is text/html. Then the browser crashes saying "Out of Memory"

Browser Crash

I use Rin 2.0.0-preview.20200813-170455, Chrome 84.0.4147.125 and Firefox Developer Edition 80.0b8 and I confirmed that the issue does not occur before e004feb.

Cause

According to the report by Firefox, Monaco allocated many objects.

Memory Tree Map

Callstack

According to my investigation, the trigger is calling editor?.layout({ width: 0, height: 0 }); in InspectorDetail.RequestResponseView.tsx.

I have not yet found out the solution which fixes this issue and does not collapse the layout even when I resize the window of the browser.

@azyobuzin azyobuzin changed the title Hung up the browser when I click Response tab Browser hangs up when I click Response tab Aug 17, 2020
@mayuki mayuki self-assigned this Aug 18, 2020
@mayuki mayuki added area-Frontend bug Something isn't working labels Aug 18, 2020
@mayuki
Copy link
Owner

mayuki commented Aug 18, 2020

Thanks for your bug report and detailed investigation!
I just fixed the unnecessary re-layout and released a new preview.

https://github.com/mayuki/Rin/releases/tag/v2.0.0-preview.4

@azyobuzin
Copy link
Contributor Author

I have confirmed that the bug has been fixed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Frontend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants