Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Generating a new theme based on the initial default creates an undeletable theme #270

Open
igniscyan opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working High Priority High Priority issues needs repro Needs reproduction

Comments

@igniscyan
Copy link

Describe the bug

I created a theme, a little over eagerly, when the default was selected. I named this theme 'test'. Now, when I attempt to delete it, I get an error prompting "Default themes can't be deleted".

Steps to reproduce

Select default theme, enter a new theme name and save, then attempt to delete new theme.

Expected behaviour

Should be able to delete anything that isn't 'Default'

Current behaviour

Unable to delete forks of 'Default' as well.

Environment

  • Plugin Version:
  • Obsidian Version:
  • Platform:
  • OS:
  • Theme:
  • CSS Snippets:

Screenshots

image

Additional context

@igniscyan igniscyan added the bug Something isn't working label Jun 27, 2024
@mayurankv
Copy link
Owner

Ahh really sorry about this. A temporary fix would be to delete the entry from the data.json file in the plugin folder but I'll look into fixing this!

@mayurankv mayurankv added needs repro Needs reproduction High Priority High Priority issues labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority High Priority issues needs repro Needs reproduction
Projects
None yet
Development

No branches or pull requests

2 participants