Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch doesn't support byte group above 2 #56

Closed
remy opened this issue Apr 25, 2021 · 2 comments
Closed

Watch doesn't support byte group above 2 #56

remy opened this issue Apr 25, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@remy
Copy link
Contributor

remy commented Apr 25, 2021

Describe the bug

If you try to watch a value grouped by 4 bytes (for 32bit) the result is wrong/corrupted.

To Reproduce

Steps to reproduce the behavior:

Add a watch for an address with 4 as the argument:

Screenshot 2021-04-25 at 10 07 46

Expected behavior

32bit groupings to be parsed. I would also expect 64bit - but I'm not sure what grouping by 3 bytes would do (or just a 24bit value?).

Version etc. (please complete the following information):

  • DeZog SW Version: 2.2.3
  • OS: macOS Big Sur
  • Remote: n/a
@maziac
Copy link
Owner

maziac commented Apr 25, 2021

Could you please try this version v2.2.4:
https://github.com/maziac/DeZog/releases/tag/v2.2.4

I have done some re-factoring. If you encounter any other problems please let me know.

@maziac maziac added the bug Something isn't working label Apr 25, 2021
@remy
Copy link
Contributor Author

remy commented Apr 25, 2021

Looks good to me 👍

@maziac maziac closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remy @maziac