Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't this filter a duplicate effort to pandoc-csv2table ? #1

Closed
KurtPfeifle opened this issue Jul 13, 2015 · 3 comments
Closed

Isn't this filter a duplicate effort to pandoc-csv2table ? #1

KurtPfeifle opened this issue Jul 13, 2015 · 3 comments
Labels

Comments

@KurtPfeifle
Copy link

You seem not to be aware of this filter:

This does a very similar thing to yours (born 2 days ago).

Wouldn't it be better if you two guys (@mb21 ad @baig) pooled your efforts into one?

@mb21
Copy link
Owner

mb21 commented Jul 13, 2015

Yes, I actually tried to use it but hit a bug. When I looked into fixing the bug, the decision to generate the table as a markdown string instead of directly generating a Pandoc AST struck me as quite error-prone and laborious, but it is a quite fundamental design decision in the filter, so I decided to roll my own, which:

  • is only ~100 lines of code instead of ~450
  • uses the spreadsheet package instead of csv, thus supports specifying custom delimiters
  • has a compile flag to not require pandoc as a dependency, so building/cabal-installing without support for inline markdown is much quicker if you installed pandoc as a binary. but when compiled with inlinemarkdown support, there is also the inlinemarkdown=yes option to turn this on/off per csv.

@KurtPfeifle
Copy link
Author

Thanks for the explanation.

Maybe you should add it to your README (or link to this issue from your README?) -- otherwise you will likely get more similar questions from other users...

@mb21 mb21 added the question label Jul 13, 2015
@mb21
Copy link
Owner

mb21 commented Jul 13, 2015

You're right, added something to the README.

@mb21 mb21 closed this as completed Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants