Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm as package manager #4

Open
mcmxcdev opened this issue Aug 28, 2022 · 2 comments
Open

Support pnpm as package manager #4

mcmxcdev opened this issue Aug 28, 2022 · 2 comments

Comments

@mcmxcdev
Copy link

After checking the source code, I realized that only npm and yarn are supported.

I have the feeling that this is a really valuable tool for people which want to be aware of potential security issues, so it would be amazing if there was official pnpm support too.

P.S.: It would be great to have a small notice of which package managers are supported in the readme, since the error Running sdc-checkError: There are no metrics data to create report wasn't telling me clearly what the issue was.

@mbalabash
Copy link
Owner

Hey @mcmxcdev!
Thanks for interest to this project.

sdc-check mostly relying on NodeSecure/scanner for data gathering and on lockfile-lint for package.lock linting. It is not possible to support pnpm in sdc-check until it is not supporting in NodeSecure/scanner.

But I think lockfile-lint is already supporting pnpm so you can use it to prevent attacks on your package.lock.

@mcmxcdev
Copy link
Author

Thanks for the detailed info.

Afaik, lockfile-lint doesn't support pnpm yet, but there is an open issue for it: lirantal/lockfile-lint#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants