-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should not allow tag-num if there is no tag #151
Comments
That's a fair point. Are you interested in contributing a fix? |
Sure, just need a pointer where to handle this. |
I think the most reasonable place to add this check would be in Something similar to what is done at the end of the function: def incr(...):
...
has_tag_part = cur_vinfo.tag != "final"
if tag_num and not has_tag_part:
logger.error("Invalid arguments, non-final --tag=<tag> is needed to use --tag-num.")
return None Tests can be added here: https://github.com/mbarkhau/bumpver/blob/master/test/test_version.py |
Created PR #153 |
Fixed with |
If a package version does not have a
tag
,bumpver update --tag-num
should not be allowed as it could create incorrect versions.Example:
The text was updated successfully, but these errors were encountered: