-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why storing current_version? #159
Comments
I could go either way on this.
If you want to work on a PR, I'll accept it. |
Just wanted to add more context on a usecase for this -- I'm currently considering a "tag only" strategy where I don't make a commit the version bump, and instead we just store the latest version in git.
As you note, it wouldn't be able to update strings in the repo. OTOH, for lightweight releases where a build pipeline kicks off for a tag, sometimes you don't want to have to commit & trigger a new pipeline just for the tag. (In my case, I've already run a fairly robust pipeline on every commit to master, so when cutting a release from a given commit, I just want to promote the image that I already built for that SHA to a numbered release.) Unfortunately I don't have bandwidth to contribute right now, but I may come back to this and see how much work it would be to add in. Just wanted to checkpoint my thinking & share it here in case it was useful. |
Hi @paultiplady, sounds like a plan +1. |
I'm running into a separate issue that the proposed change may address as well. I develop using docker and use multi-stage builds where I first copy Here's a blog that touches on this: https://pythonspeed.com/articles/poetry-vs-docker-caching/ I suppose the most sensible workaround for this would be to use |
This is also something that bothers me a bit. Because
The config parser is happy. Additionally |
Accordin to the README:
so, why does bumpver forces me to also add my current_version to
pyproject.toml
? I don't like the idea of having my version stored in two different places, and it would create unusefull diffs when changing both.If I remove
current_version
frompyproject.toml
I'm getting:The text was updated successfully, but these errors were encountered: