Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action on drag-and-drop to the outside of sidebar: Open in new window not working when another browser window doesn't have Sidebery open #1554

Closed
myuwi opened this issue Mar 28, 2024 · 0 comments

Comments

@myuwi
Copy link

myuwi commented Mar 28, 2024

Steps to reproduce

  • Open Firefox in a new profile
  • Install Sidebery
  • Open two Firefox windows, one with Sidebery visible and one with it hidden
  • Open a second tab on the one with Sidebery visible, and try to drag the tab outside the Sidebery sidebar to open it in a new window

Video:

sidebery-repro.mp4

Actual behavior

Tab doesn't open in a new window even though Action on drag-and-drop to the outside of sidebar is set to Open in new window. (default behavior)

I'm pretty sure this is caused by this Promise.all() call rejecting due to Sidebery failing to check every window for the tab's drop status (because they don't have Sidebery open).

Expected behavior

Dragged tab opens in a new window.

System

Arch Linux

Firefox version

124.0.1

Sidebery version

5.2.0

Logs

[sidebar:1] IPC.request: Cannot find appropriate port, trying to reconnect... chunk-4KZVVU6Z.js:2:7976
[sidebar:1] IPC.connectTo: No confirmation: sidebar chunk-4KZVVU6Z.js:2:7976
[sidebar:1] IPC.request: No confirmation: sidebar isDropEventConsumed chunk-4KZVVU6Z.js:2:7976
[sidebar:1] DnD.onDragEnd: Cannot get drop status from other windows
 IPC.request: No port chunk-4KZVVU6Z.js:3:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants