Skip to content

Commit 2773c0c

Browse files
Log stack traces from exceptions thrown by devicelab test tasks (flutter#171165)
1 parent 6e68383 commit 2773c0c

18 files changed

+36
-19
lines changed

dev/devicelab/bin/tasks/android_obfuscate_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ Future<void> main() async {
106106
return TaskResult.success(null);
107107
} on TaskResult catch (taskResult) {
108108
return taskResult;
109-
} catch (e) {
109+
} catch (e, stackTrace) {
110+
print('Task exception stack trace:\n$stackTrace');
110111
return TaskResult.failure(e.toString());
111112
}
112113
});

dev/devicelab/bin/tasks/android_release_builds_exclude_dev_dependencies_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ Future<void> main() async {
100100
return TaskResult.success(null);
101101
} on TaskResult catch (taskResult) {
102102
return taskResult;
103-
} catch (e) {
103+
} catch (e, stackTrace) {
104+
print('Task exception stack trace:\n$stackTrace');
104105
return TaskResult.failure(e.toString());
105106
}
106107
});

dev/devicelab/bin/tasks/build_aar_module_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,8 @@ Future<void> main() async {
265265
return TaskResult.success(null);
266266
} on TaskResult catch (taskResult) {
267267
return taskResult;
268-
} catch (e) {
268+
} catch (e, stackTrace) {
269+
print('Task exception stack trace:\n$stackTrace');
269270
return TaskResult.failure(e.toString());
270271
} finally {
271272
rmTree(tempDir);

dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,8 @@ class ModuleTest {
447447
return TaskResult.success(null);
448448
} on TaskResult catch (taskResult) {
449449
return taskResult;
450-
} catch (e) {
450+
} catch (e, stackTrace) {
451+
print('Task exception stack trace:\n$stackTrace');
451452
return TaskResult.failure(e.toString());
452453
} finally {
453454
rmTree(tempDir);

dev/devicelab/bin/tasks/build_android_host_app_with_module_source.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,8 @@ class ModuleTest {
391391
return TaskResult.success(null);
392392
} on TaskResult catch (taskResult) {
393393
return taskResult;
394-
} catch (e) {
394+
} catch (e, stackTrace) {
395+
print('Task exception stack trace:\n$stackTrace');
395396
return TaskResult.failure(e.toString());
396397
} finally {
397398
rmTree(tempDir);

dev/devicelab/bin/tasks/build_ios_framework_module_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ Future<void> main() async {
5151
return TaskResult.success(null);
5252
} on TaskResult catch (taskResult) {
5353
return taskResult;
54-
} catch (e) {
54+
} catch (e, stackTrace) {
55+
print('Task exception stack trace:\n$stackTrace');
5556
return TaskResult.failure(e.toString());
5657
} finally {
5758
rmTree(tempDir);

dev/devicelab/bin/tasks/flutter_engine_group_performance.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ Future<TaskResult> _doTest() async {
8181
_copyGradleFromModule(modulePath, androidPath);
8282

8383
await utils.eval(gradlewExecutable, <String>['assembleRelease'], workingDirectory: androidPath);
84-
8584
final String apkPath = path.join(
8685
multipleFluttersPath,
8786
'android',
@@ -119,7 +118,8 @@ Future<TaskResult> _doTest() async {
119118
});
120119

121120
return result ?? TaskResult.failure('no results found');
122-
} catch (ex) {
121+
} catch (ex, stackTrace) {
122+
print('Task exception stack trace:\n$stackTrace');
123123
return TaskResult.failure(ex.toString());
124124
}
125125
}

dev/devicelab/bin/tasks/gradle_desugar_classes_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ Future<void> main() async {
3838
return TaskResult.success(null);
3939
} on TaskResult catch (taskResult) {
4040
return taskResult;
41-
} catch (e) {
41+
} catch (e, stackTrace) {
42+
print('Task exception stack trace:\n$stackTrace');
4243
return TaskResult.failure(e.toString());
4344
}
4445
});

dev/devicelab/bin/tasks/gradle_java8_compile_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ class AaaPlugin: FlutterPlugin, MethodCallHandler {
9090
return TaskResult.success(null);
9191
} on TaskResult catch (taskResult) {
9292
return taskResult;
93-
} catch (e) {
93+
} catch (e, stackTrace) {
94+
print('Task exception stack trace:\n$stackTrace');
9495
return TaskResult.failure(e.toString());
9596
}
9697
});

dev/devicelab/bin/tasks/gradle_plugin_bundle_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ Future<void> main() async {
172172
return TaskResult.success(null);
173173
} on TaskResult catch (taskResult) {
174174
return taskResult;
175-
} catch (e) {
175+
} catch (e, stackTrace) {
176+
print('Task exception stack trace:\n$stackTrace');
176177
return TaskResult.failure(e.toString());
177178
}
178179
});

0 commit comments

Comments
 (0)