Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickers as a peer dependency #2259

Closed
eps1lon opened this issue Aug 1, 2020 · 2 comments
Closed

pickers as a peer dependency #2259

eps1lon opened this issue Aug 1, 2020 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@eps1lon
Copy link
Contributor

eps1lon commented Aug 1, 2020

Describe the bug
Direct dependency of @material-ui/pickers can lead to duplicate versions in the bundle. This has a negative impact on bundle size. It can also prevent localization of the date picker used by material-table since the context is created in different packages

To Reproduce
Steps to reproduce the behavior:

  1. Install material-ui-table
  2. new release of @material-ui/pickers
  3. Install (and use) @material-ui/pickers in the app
  4. duplicate version of @material-ui/pickers

Expected behavior
@material-ui/pickers is a peer dependency.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: N/A
  • Browser N/A
  • Version 1.67.1

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser N/A
  • Version 1.67.1

Additional context

Same issue as #472

@stale
Copy link

stale bot commented Oct 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

@stale stale bot added the wontfix This will not be worked on label Oct 30, 2020
@eps1lon
Copy link
Contributor Author

eps1lon commented Oct 30, 2020

bump

@stale stale bot closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant