Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Documentation Mismatch #115

Closed
utdrmac opened this issue Jun 17, 2015 · 2 comments
Closed

Configuration Documentation Mismatch #115

utdrmac opened this issue Jun 17, 2015 · 2 comments

Comments

@utdrmac
Copy link

utdrmac commented Jun 17, 2015

The code shows this:

static MYSQL_SYSVAR_STR(whitelist_cmds, whitelist_cmds_string,
            PLUGIN_VAR_RQCMDARG,
            "AUDIT plugin commands to skip, comma separated",
            NULL, whitelist_cmds_string_update, NULL);
static MYSQL_SYSVAR_STR(record_cmds, record_cmds_string,
            PLUGIN_VAR_RQCMDARG,
            "AUDIT plugin whitelisted commands for which queries are not recorded, comma separated",
            NULL, record_cmds_string_update, NULL);

The above says "audit_record_cmds" is a whitelist-style setting. But the documentation (wiki/Configuration) says "Comma separated list of commands to log to the audit trail."

So which is it? It seems I'm getting audit logging regardless of the setting.

@glicht
Copy link
Contributor

glicht commented Jun 19, 2015

Thanks for reporting this. We will put in a fix in the description in the
code.
On Jun 17, 2015 8:14 PM, "Matthew" notifications@github.com wrote:

Documentation also states that 'audit_record_objs' should be listed using
dot-notation. However, I've found that setting "." leaves out almost
50% of the queries. Setting this to empty string gets everything.


Reply to this email directly or view it on GitHub
#115 (comment).

glicht added a commit that referenced this issue Jul 12, 2015
@glicht glicht closed this as completed Jul 12, 2015
@aharonrobbins
Copy link

1.0.9 should be released by the end of Q1 2016.

Thanks,

Aharon

Aharon (Arnold) Robbins
Senior Software Engineer
Sensor - Database Security
McAfee. Part of Intel Security.
[cid:image003.png@01CF5AF2.16A4D380]

From: billakantisatish [mailto:notifications@github.com]
Sent: Thursday, January 21, 2016 09:30
To: mcafee/mysql-audit mysql-audit@noreply.github.com
Subject: Re: [mysql-audit] Configuration Documentation Mismatch (#115)

When the v1.0.9 will be released?


Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-173482850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants