Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realpath() does not gracefully continue when an input file does not exist #19

Open
mcauley-penney opened this issue Dec 14, 2023 · 0 comments

Comments

@mcauley-penney
Copy link
Owner

mcauley-penney commented Dec 14, 2023

Problem: The realpath fn is used to resolve paths so that we can deduplicate paths that are given with different forms, e.g. we want to remove duplicates even in situations when a relative and absolute path are given for the same item. As of now, mmv segfaults when given a path that does not exist.

Proposed solution: Continue when a path doesn't exist. We can use this an opportunity to filter inputs that aren't real. This may not be a small edge case either: I found this by accidentally using mmv like mv: I provided a destination name that didn't exist in my file system. This is probably a common mistake for command line users, I do this kind of regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant