Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import parser properly delegates to resource location parser #37

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

TheWii
Copy link
Contributor

@TheWii TheWii commented Aug 12, 2022

I noticed that the bolt:import parser uses parsers["resource_location_or_tag"] to get the resource_location_or_tag parser (instead of using the delegate function), making it impossible to be overridden.

@vberlier
Copy link
Member

Yeah I think using delegate would be desirable here but you need to wrap it with DisableInterpolationParser since bolt overrides resource_location_or_tag to enable interpolation.

@vberlier vberlier merged commit a971b07 into mcbeet:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants