Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Google Cloud Storage? #6

Open
pbilling opened this issue Jul 29, 2022 · 2 comments
Open

Support for Google Cloud Storage? #6

pbilling opened this issue Jul 29, 2022 · 2 comments

Comments

@pbilling
Copy link

I was made aware that you can run Samplot-ML on Google Cloud Platform (https://docs.google.com/document/d/1EfrNv6Y5aGDbQ3Je5jBI83owdOveVbmqIP6fuCDmEEw), but from the workflows/conf/samplot-ml-predict.yaml config file it looks like only local and S3 storage are supported. Is Google Cloud Storage supported as well?

@mchowdh200
Copy link
Owner

Hi pbilling!
Out of the box it does not, but it would not be to difficult to implement.

  • In samplot-ml/workflows/config_utils.py, I have a abstract class Data from which I derived the S3Data and LocalData types.

  • To implement support GCP, you could write another class (say GCPData...) and implement the get_cmd method. The goal of this method is to return the command that will be run by the snakemake rule that gets the alignment file data. For example the S3Data type returns a string containing a call to the aws-cli.

  • In addition to implementing this class, we also add a elif clause in the data_factory function in config_utils.py.

I don't use google cloud myself, so I wouldn't know the exact commands to use myself, but I am open to accepting a pull request for an implementation

@pbilling
Copy link
Author

Great, thanks @mchowdh200! Looks simple enough, I'll see about adding GCP support.

Best,
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants