Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Objective function that the NOTEARS algorithm with lasso regularisation #239

Open
1 task done
RuikeZ opened this issue Jul 26, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@RuikeZ
Copy link

RuikeZ commented Jul 26, 2024

Contact Details

ruikezhang2013@gmail.com

Short description of the problem here.

Hi, I've noticed the Lasso regularisation is using w_vec.sum() in https://github.com/mckinsey/causalnex/blob/0.4.2/causalnex/structure/notears.py#L489
loss + 0.5 * rho * h_val * h_val + alpha * h_val + beta * w_vec.sum()
wondering if it makes more sense to use np.linalg.norm(w_est)?

CausalNex Version

0.4.2

Python Version

3.10

Relevant code snippet

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@RuikeZ RuikeZ added the bug Something isn't working label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant