Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process.hrtime not available in browser #5

Closed
DenisCarriere opened this issue Apr 5, 2017 · 1 comment
Closed

process.hrtime not available in browser #5

DenisCarriere opened this issue Apr 5, 2017 · 1 comment

Comments

@DenisCarriere
Copy link
Collaborator

DenisCarriere commented Apr 5, 2017 •
edited
Loading

process.hrtime is not a valid function in the browser.

Have this ever been tested in the browser? Tests are passing fine in NodeJS.

https://github.com/mclaeysb/simplepolygon/search?utf8=%E2%9C%93&q=process.hrtime&type=

Might be handy to set up a simple /docs folder with an index.html and a browser friendly build to simply test this library in the browser. Here's a "minimalistic" approach I've been doing for some of my libraries https://github.com/DenisCarriere/slippy-tile/tree/master/docs.

I can send a PR to include a simple Rollup config that builds the bundle, let me know.

For this type of debugging/timings, you could look into including debug for your internal testing/debugging.
@DenisCarriere DenisCarriere mentioned this issue Apr 6, 2017
Merged
@mclaeysb
Copy link
Owner

mclaeysb commented Apr 9, 2017

Closed thanks to #6

@mclaeysb mclaeysb closed this as completed Apr 9, 2017
@DenisCarriere DenisCarriere mentioned this issue Apr 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DenisCarriere @mclaeysb