Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scaling feature is turned on the title doesn't show in a consistent place or size #184

Closed
Zamrod opened this issue Jul 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Zamrod
Copy link

Zamrod commented Jul 8, 2023

If you turn on the scale label for the zoom level feature, the health estimate text doesn't stay at the top (or wherever you have it set), it slowly moves down depending on what zoom level you are at. It also is unaffected by the text size setting except if you zoom in far enough then suddenly the text size setting will apply. It'll suddenly change size dramatically at that zoom level and above.

Expected behavior
I would expect the text to stay in the same position relative to the token it is hovering over no matter what the zoom level and for the text size setting to affect the size consistently.

Screenshots
Zoomed in with the text size set to 8. Position -65. Scaling on:
image

Same settings Zoomed all the way out:
image

Position set to -30 with otherwise the same settings as above. Zoomed in to the very first zoom level when the font size setting seems to apply:
image

One zoom level out from the above picture:
image

Same as the above but zoomed all the way out. Now the text starts to cover a large portion of the token:
image

Game Specifics (please complete the following information):

  • dnd5e 2.2.2
  • Foundry 11.305

Additional context
I think the key might just be changing the zoom point to the bottom of the text instead of the middle (or maybe the top of the text when below the halfway point of the token?

@Zamrod Zamrod added the bug Something isn't working label Jul 8, 2023
@mclemente
Copy link
Owner

Yes, it can be improved by a lot. I'll take a shot at changing this when I have the time (~1 month from now).
Back when it was implemented I couldn't find a better way to get the placement right for all 3 positions and it was only tested at the default text size (24).
Also, I appreciate the feedback on the zoom point, that's something I'll test once I get to it.

@mclemente
Copy link
Owner

I've changed the behavior on v31.6 to be more consistent, check it out and let me know if anything is out of place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants