Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Persistance Support #36

Merged
merged 30 commits into from
Jun 26, 2013
Merged

Persistance Support #36

merged 30 commits into from
Jun 26, 2013

Conversation

mcollina
Copy link
Collaborator

Closes #17.
Closes #21.
Closes #24.
Closes #38.

@mcollina
Copy link
Collaborator Author

I am getting some super-good benchmarks here:

Mosquitto

$ ./benchmarks/single_pub_sub.js --header -q 1 -r 10000
mean, standard deviation, median, mode, runs
1317.389, 2621.9008969056513, 1088, 165, 10000

Mosca

$ ./benchmarks/single_pub_sub.js --header -q 1 -r 10000
mean, standard deviation, median, mode, runs
208.6827, 252.84635984089678, 185, 170, 10000

It seems Mosquitto implementation of the persistance does not really scale to multiple runs.

Thanks also to @davedoesdev and its outstanding https://github.com/davedoesdev/qlobber.

@davedoesdev
Copy link
Contributor

Excellent! What would be interesting is benchmarks for topics using wildcards.
Are you sure mosca was using TrieAscoltatore? Doesn't ascoltatore build MemoryAscoltatore unless it's specified?

Edit: Ah got it - you made the change in Ascoltatori to change the default.

Edit: Actually you forgot to do it ascoltatori.build so I don't think you were testing using TrieAscoltatore? I've made the changes in moscajs/ascoltatori#62

@mcollina
Copy link
Collaborator Author

I am directly using Qlobber in the persistance support.
The latest version of Ascoltatori uses TrieAscoltatore (I think 0.7.3)

Il giorno mercoledì 26 giugno 2013, David Halls ha scritto:

Excellent! What would be interesting is benchmarks for topics using
wildcards.
Are you sure mosca was using TrieAscoltatore? Doesn't ascoltatore build
MemoryAscoltatore unless it's specified?


Reply to this email directly or view it on GitHubhttps://github.com//pull/36#issuecomment-20029049
.

@davedoesdev
Copy link
Contributor

I think you missed out ascoltatori.build

@mcollina
Copy link
Collaborator Author

Yes, you are right! I'm merging in your PR asap.

Il giorno mercoledì 26 giugno 2013, David Halls ha scritto:

I think you missed out ascoltatori.build


Reply to this email directly or view it on GitHubhttps://github.com//pull/36#issuecomment-20030563
.

mcollina added a commit that referenced this pull request Jun 26, 2013
@mcollina mcollina merged commit e4d2aa6 into master Jun 26, 2013
@mcollina mcollina deleted the persistance branch June 26, 2013 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants