Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msgpack5 throws when encoding NaN, contrary to spec #93

Closed
ninevra opened this issue Feb 11, 2021 · 0 comments · Fixed by #94
Closed

msgpack5 throws when encoding NaN, contrary to spec #93

ninevra opened this issue Feb 11, 2021 · 0 comments · Fixed by #94

Comments

@ninevra
Copy link
Contributor

ninevra commented Feb 11, 2021 •
edited
Loading

Since #75, msgpack5 throws an error when attempting to encode NaN. The error states that NaN is not encodable in msgpack!. This appears to be contrary to the spec, which states that "Float represents a IEEE 754 double precision floating point number including NaN and Infinity".

Of note: msgpack5 already correctly deserializes NaN.
@ninevra ninevra mentioned this issue Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow NaN ninevra/msgpack5
1 participant
@ninevra