Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ListView in upperLayer section cancel the drag up action #4

Closed
icarus31 opened this issue Jan 2, 2019 · 5 comments
Closed

Using ListView in upperLayer section cancel the drag up action #4

icarus31 opened this issue Jan 2, 2019 · 5 comments

Comments

@icarus31
Copy link

icarus31 commented Jan 2, 2019

Describe the bug
I have a column with multiple rows in my upperLayer section. If I leave at it is, I get a "Bottom overflowed" error.

Column(
  children: <Widget>[
    Row(
      children: <Widget> [
      ...
      ]),
    Row(
      children: <Widget> [
      ...
      ]),
  ])

Putting the column within a ListView or similar widget remove the overflow, but now, when dragging up the section, it just scroll the ListView:

ListView(
  children: <Widget> [
    Column(
      children: <Widget>[
        Row(
          children: <Widget> [
          ...
          ]),
        Row(
          children: <Widget> [
          ...
        ]),
      ])
    ])
....

Smartphone (please complete the following information):

  • Device: Blackberry Motion
  • OS: Android 8.x
  • Flutter 1.0 and Rubber 0.2.1
@JohannesKaufmann
Copy link

I had the same problem. If you use

new SingleChildScrollView(
        physics: const NeverScrollableScrollPhysics(),
        child: new Column(...),
)   

you can scroll the modal again but not the actual list. So I tried to toggle between NeverScrollableScrollPhysics and null whenever the user hit the top of the list but I was not able to get it to work.

For anyone trying it out, have a look at

  • NotificationListener: OverscrollNotification and ScrollEndNotification
  • ScrollController: position.pixels and position.userScrollDirection

@mcrovero
Copy link
Owner

mcrovero commented Jan 3, 2019

I'm currently implementing the upper layer scrolling feature for my own project so it will be supported in the next release.
Thanks for your interest in the project!

@icarus31
Copy link
Author

icarus31 commented Jan 4, 2019

Hi @mcrovero,

I don't want to rush you, by any idea when you think you will release it?

Thanks

@mcrovero
Copy link
Owner

mcrovero commented Jan 7, 2019

New version published! 😉
Let me know if you find any issues

@icarus31
Copy link
Author

icarus31 commented Jan 7, 2019

Nice job! Working good with my gridview too! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants