Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not vertical layout friendly #7

Closed
diggit opened this issue Oct 27, 2022 · 10 comments
Closed

Not vertical layout friendly #7

diggit opened this issue Oct 27, 2022 · 10 comments

Comments

@diggit
Copy link

diggit commented Oct 27, 2022

Hi,
memview does not work well with high and narrow panels.

image

It automatically hides addresses and leaves ASCII decoding enabled. Top bar is not properly aligned with contents below.
I'd rather see addresses than ASCII decoding. Preferably configurable behavior.

Also, memview does not readjust its' width, when panel changes dimensions. Manual memview refresh has to be done.

It's great to see active development of memory view :)

@haneefdm
Copy link
Contributor

Hmmm. Not even sure how this is possible. By any chance, the addresses showed up on far right?

Also, memview does not readjust its' width, when panel changes dimensions. Manual memview refresh has to be done.

Also, noted.

@diggit
Copy link
Author

diggit commented Nov 1, 2022

Hi,
I have installed: mcu-debug.memory-view v0.0.14 (Preview)

here are some details about behavior:

Moved panel to right, made it wide enough and refreshed memory view
image

Shrunk a little bit. Individual addresses became scrollable.
image

And even more...
image

And then they completely disappear.
image

Memview becomes horizontally scrollable to fit contents and ascii decode, but addresses are nowhere to be seen.

I guess, something is missing "minimum width" property or so.

@haneefdm
Copy link
Contributor

haneefdm commented Nov 1, 2022

I should have posted this yesterday. While I fixed the missing (shrunk) address problem, I am having issues with the horizontal scrollbar -- I have two methods and neither of them work right. In once case, the header row does not horizontally scroll and in another the whole thing scrolls and in a weird way that includes the vertical scrollbar and its idea of the content width is totally wrong.

I have yet another way where you never see the horizontal scrollbar it seems to work much better. Maybe, temporarily, this is what I will release for now.

@haneefdm
Copy link
Contributor

I pushed an update to the marketplace just now 0.0.16. See Changelog. The header does not horizontally scroll but the content does. We don't know what is wrong or how to fix it and seeking help from the community.

But, the vertical bar works pretty well in our testing.

Best we can do for now.

@haneefdm
Copy link
Contributor

I am not gong to close this but please give us feedback if you have the time

@hongshui3000
Copy link

I am showing incomplete data here 0.0.16
image

@haneefdm
Copy link
Contributor

@hongshui3000 Did you change the editor font-size in VSCode by any chance? Was this the same with the previous version? It appears that the line-height is not enough. I am not sure how to duplicate this.

Btw, this is a separate issue from the original issue of very narrow windows.

@hongshui3000
Copy link

font-size
image

@haneefdm
Copy link
Contributor

line spacing issue is fixed in latest release in the marketplace.

@haneefdm
Copy link
Contributor

I am closing this for now. The horizontal scrolling could be a separate issue and not as pressing. The original issue has long been solved and I don't want people to use this issue to add other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants