Add boot_state_init and fix boot_state_clear (and usage) #2526
+45
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
inits-and-deinits
branch
2 times, most recently
from
2a8e7fa to
2420ff6
Compare
nordicjm
approved these changes
Oct 29, 2025
boot_loader_state initialization function. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Replace boot_state_clear with boot_state_init, where used for initialization and add boot_state_clear to remove state after use. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Initialize boot_loader_state with boot_state init, then clean it up, after use, with boot_state_clear. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
No need to keep this defaulting logic. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Call boot_enc_deinit before memset to 0. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
inits-and-deinits
branch
from
ce5e457 to
d391e70
Compare
nvlsianpu
reviewed
Oct 29, 2025
| #if defined(MCUBOOT_ENC_IMAGES) | ||
| for (image = 0; image < BOOT_IMAGE_NUMBER; ++image) { | ||
| for (slot = 0; slot < BOOT_NUM_SLOTS; ++slot) { | ||
| boot_enc_init(&state->enc[image][slot]); |
There was a problem hiding this comment.
whatever was pointed by state get zeroized already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds
boot_state_initthat is intended to be used for boot_loader_state object initialization.The
boot_state_initis then used in places whereboot_state_clearhas been previously used for state initialization and paired withboot_state_clearto cleanup state when it is no longer used.