Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dark mode #1906

Closed
kingdomac opened this issue Sep 1, 2023 · 2 comments · Fixed by #1915
Closed

Modal dark mode #1906

kingdomac opened this issue Sep 1, 2023 · 2 comments · Fixed by #1915
Assignees
Milestone

Comments

@kingdomac
Copy link

When using the modal in dark mode, the input border arn't visible.

@juujisai
Copy link
Contributor

juujisai commented Sep 4, 2023

Hi, thanks for letting us know. We will fix that

@juujisai juujisai added this to the v1.0.0-rc.2 milestone Sep 4, 2023
@juujisai juujisai modified the milestones: v1.0.0-rc.2, v1.0.0 Sep 6, 2023
@juujisai juujisai self-assigned this Sep 6, 2023
@juujisai juujisai linked a pull request Sep 6, 2023 that will close this issue
@juujisai juujisai closed this as completed Sep 6, 2023
@juujisai
Copy link
Contributor

juujisai commented Sep 6, 2023

We have updated the docs for modals. There are 2 things that can be done:

  1. Change the notches colors like that:
<div
  class="relative mb-6"
  data-te-input-wrapper-init
  data-te-class-notch-leading-normal="border-neutral-300 dark:border-neutral-400 group-data-[te-input-focused]:shadow-[-1px_0_0_#3b71ca,_0_1px_0_0_#3b71ca,_0_-1px_0_0_#3b71ca] group-data-[te-input-focused]:border-primary"
  data-te-class-notch-middle-normal="border-neutral-300 dark:border-neutral-400 group-data-[te-input-focused]:shadow-[0_1px_0_0_#3b71ca] group-data-[te-input-focused]:border-primary"
  data-te-class-notch-trailing-normal="border-neutral-300 dark:border-neutral-400 group-data-[te-input-focused]:shadow-[1px_0_0_#3b71ca,_0_-1px_0_0_#3b71ca,_0_1px_0_0_#3b71ca] group-data-[te-input-focused]:border-primary">
  1. Change the dark:bg-neutral-600 class under data-te-modal-dialog-ref element to dark:bg-neutral-400 or anything you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants