Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manipulator refactor #1294

Closed
smolenski-mikolaj opened this issue Feb 2, 2023 · 0 comments · Fixed by #1309
Closed

Manipulator refactor #1294

smolenski-mikolaj opened this issue Feb 2, 2023 · 0 comments · Fixed by #1309
Assignees
@juujisai
Labels
optimization refactor
Milestone
v1.0.0-beta1

Comments

@smolenski-mikolaj
Copy link
Contributor

smolenski-mikolaj commented Feb 2, 2023 •
edited
Loading

  • merge bs/src/dom/manipulator.js and mdb/dom/manipulator.js
  • move to src/js/dom/
  • remove addMultiClass, removeMultiClass, addMultipleClasses methods
  • refactor addClass method so that it checks if className is string or array, and if string then it splits and checks in element contains class. This method should parse correctly a) strings b) arrays c) strings with mutliple classes
  • same for removeClass & toggleClass(?)
@smolenski-mikolaj smolenski-mikolaj converted this from a draft issue Feb 2, 2023
@smolenski-mikolaj smolenski-mikolaj changed the title Manipulator bs and mdb - unify and remove all class methods - use element.classList instead and loops for arrays or splitted strings Manipulator refactor Feb 2, 2023
@smolenski-mikolaj smolenski-mikolaj added this to the v1.0.0-beta1 milestone Feb 2, 2023
@smolenski-mikolaj smolenski-mikolaj mentioned this issue Feb 2, 2023
Closed
@juujisai juujisai linked a pull request Feb 9, 2023 that will close this issue
Move content to the roots and manipulator refactor #1309
Merged
@github-project-automation github-project-automation bot moved this from Pending to Done in Tailwind Elements Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juujisai juujisai

Labels
optimization refactor
Projects
Tailwind Elements
Status: Done
Milestone
v1.0.0-beta1
Development

Successfully merging a pull request may close this issue.

Move content to the roots and manipulator refactor mdbootstrap/TW-Elements
2 participants
@smolenski-mikolaj @juujisai