Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 3.* it's supported? #1155

Closed
snessnes opened this issue Feb 22, 2017 · 7 comments
Closed

jQuery 3.* it's supported? #1155

snessnes opened this issue Feb 22, 2017 · 7 comments

Comments

@snessnes
Copy link

snessnes commented Feb 22, 2017

jQuery 3.* it's supported?

Example: https://jsfiddle.net/snessnes/vxr1vLyu/

Elements not show normally and errors in console when click links.

Uncaught Error: Syntax error, unrecognized expression: #
at Function.ga.error (jquery.min.js:2)
at ga.tokenize (jquery.min.js:2)
at ga.select (jquery.min.js:2)
at Function.ga [as find] (jquery.min.js:2)
at r.fn.init.find (jquery.min.js:2)
at r.fn.init (jquery.min.js:2)
at r (jquery.min.js:2)
at b (bootstrap.min.js:6)
at HTMLAnchorElement. (bootstrap.min.js:6)
at Function.each (jquery.min.js:2)

@FezVrasta
Copy link
Contributor

it should support what bootstrap supports

@snessnes
Copy link
Author

View example throw errors with jQuery 3.* , but with 2.* not

@FezVrasta
Copy link
Contributor

Are you sure these errors are thrown by the JS shipped with this theme? To me it looks like it's bootstrap.min.js fault

@snessnes
Copy link
Author

I using Oficial jQuery 3.1.1 with Oficial bootstrap 3.3.7
Can you provide me a example using this technology?

@migerh
Copy link

migerh commented Mar 5, 2017

Seems to be a known problem in bootstrap: twbs/bootstrap#21328

@derwok
Copy link

derwok commented Mar 5, 2017

For our project 4Minitz we had the same issue - after migrating from jQuery 2.x to jQuer 3.x. It seems the root cause was a breaking incompatibility of Twitter Bootstrap2 => Bootstrap3 migration. (see comment of @migerh above).

To make a long story short:
This dropdown trigger broke our whole application:
<a href="#" id="navbar-usermenu" data-target="#" class="dropdown-toggle" data-toggle="dropdown">

To fix it, we removed this attribute: data-target="#" - the attribute is only needed when dropdown-trigger and dropdown-menu are not direct siblings and are locate apart from each other. Now this works for us:

<a href="#" id="navbar-usermenu" class="dropdown-toggle" data-toggle="dropdown">

Now everything works fine - even with jQuery v3 & Bootstrap v3!

@NicoJuicy
Copy link

Other workarround, update to bootstrap 3.4.1. The dropdown now works without jQuery.

twbs/bootstrap@90261b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants