Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: navigate event - add Bugzilla reference #21952

Closed
erosman opened this issue Jan 18, 2024 · 9 comments · Fixed by #21970
Closed

Navigation: navigate event - add Bugzilla reference #21952

erosman opened this issue Jan 18, 2024 · 9 comments · Fixed by #21970
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@erosman
Copy link
Contributor

erosman commented Jan 18, 2024

What type of issue is this?

Other

What information was incorrect, unhelpful, or incomplete?

Add Bug 1777171: Implement Navigation API reference to navigate

What browsers does this problem apply to, if applicable?

Firefox

What did you expect to see?

Reference added

Did you test this? If so, how?

n/a

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

No response

Do you have anything more you want to share?

No response

MDN URL

No response

MDN metadata

No response

@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 19, 2024
@queengooborg
Copy link
Contributor

Hey @erosman! Would you be down submit a PR to add this?

@erosman
Copy link
Contributor Author

erosman commented Jan 19, 2024

I am not familiar with the browser-compat-data PR process.
Is there a similar example that I can look at?

@queengooborg
Copy link
Contributor

queengooborg commented Jan 20, 2024

Oh! I could have sworn you had written a PR or two before, my apologies!

Adding the bug URL is pretty straightforward, you can reference #21907 as an example. Additionally, you can review the description of BCD's file schema here: https://github.com/mdn/browser-compat-data/blob/main/schemas/compat-data-schema.md

If you ever need assistance, you are always welcome to reach out to us!

@erosman
Copy link
Contributor Author

erosman commented Jan 20, 2024

You must be on a branch to make or propose changes to this file

Which branch would that be?

@queengooborg
Copy link
Contributor

Where are you seeing that message?

@erosman
Copy link
Contributor Author

erosman commented Jan 22, 2024

When I click the edit button...

image

@queengooborg
Copy link
Contributor

Huh...that's...odd. I'm noticing that you don't have the branch selection dropdown either. What URL are you on? https://github.com/mdn/browser-compat-data/blob/main/api/Navigation.json?

@erosman
Copy link
Contributor Author

erosman commented Jan 22, 2024

I was on a permanent URL (resulted from searching for navigate)

I will try again.

@queengooborg
Copy link
Contributor

Ah, that explains it -- yeah, if you're on a commit blob, you won't be able to use the Edit button!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants