Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to Chrome Runtime Flags should use link form instead of text form. #2992

Closed
jpmedley opened this issue Oct 15, 2018 · 2 comments
Closed
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project. linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@jpmedley
Copy link
Contributor

Chrome runtime flags (accessed at chrome://flags have two forms: a string that appears as a heading and a URL anchor form. Google prefers that the anchor form be used because it's less likely to change than the string form.

This ticket is to track two tasks made at @Elchi3's request:

  • Document this preference in an appropriate place. (In the schema documentation?)
  • Make this testable so that existing and future references to flags will be corrected. (Schema change?)
@Elchi3 Elchi3 added docs ✍️ Issues or pull requests regarding the documentation of this project. linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. labels Oct 15, 2018
@jpmedley
Copy link
Contributor Author

@Elchi3 Can you please hold off on updating the linter until you hear from me again. Many of our flags are not intended for tire kicking. We are working on pulling that information from Chrome Status. This request may turn out to be 'don't allow Chrome flags.' I'll keep you posted.

@Elchi3
Copy link
Member

Elchi3 commented Mar 24, 2020

I never heard back from Joe and there was also no answer from Joe in recent PRs on this issue. See e.g. #5504 (comment)

Closing.

@Elchi3 Elchi3 closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project. linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

No branches or pull requests

2 participants