CI fails when changed files have parens in file path

[bsmth]

Update:

We have agreed to ban parentheses from file names and renamed the offending paths:

• fix: rename files/slugs with parens #20470

CI checks are being put in place to ban new files from being added with parentheses:

• enhance(filecheck): validate all file paths for lowercase and special characters yari#8019

---

Failing workflow:
https://github.com/mdn/content/actions/runs/3908866554/jobs/6679383140

Changed files:

• files/en-us/glossary/descriptor_(css)/index.md
• files/en-us/glossary/round_trip_time_(rtt)/index.md
• files/en-us/glossary/xhr_(xmlhttprequest)/index.md

Refers to line 5 in the script, which looks like:

content/.github/workflows/pr-test.yml

Lines 90 to 95 in ebd19ef

	run: |
	# The reason this script isn't in `package.json` is because
	# you don't need that script as a writer. It's only used in CI
	# and it can't use the default CONTENT_ROOT that gets set in
	# package.json.
	yarn build ${{ env.GIT_DIFF_CONTENT }}

i.e.:

yarn build files/en-us/glossary/descriptor_(css)/index.md

Where the following should work:

yarn build "files/en-us/glossary/descriptor_(css)/index.md"

Maybe we should try wrapping these file paths in quotes

CCing @yin1999 @schalkneethling

[yin1999]

I'll have a look on this

[yin1999]

I'll have a look on this

Try to fix this in #23608

[OnkarRuikar]

• The PR fix: rename files/slugs with parens #20470 is supposed to fix these file names. But is on hold for a long time, we need conclude the community discussion. May be bring up the issue in next meeting?

---

Command syntax, mainly shell expansions, are a little bit different for each shell -- newer shells like Z shell and fish are more forgiving than Bash. So scripts/commands that work in these shell may not work exactly the same on bash. If you are using Apple products then most likely you are using Z shell and not Bash.
Our GitHub workflows use ubuntu-22.04 (need to check the shell and version). This is important because, I think the expansions are not happening the same as they happen in our local environment.

[estelle]

It looks like no files with a ( can be edited right now. See #23620. I updated via the Github UI, and it's failing due to the parenthesis.

[OnkarRuikar]

It looks like no files with a ( can be edited right now. See #23620. I updated via the Github UI, and it's failing due to the parenthesis.

The change in PR is small and not affecting anything, so for now we can force merge it with failing workflow. We already do this for infrastructure related PRs e.g. #22874.
Then try to merge #20470 as soon as we can.

[bsmth]

Thanks, all. I went ahead and merged Estelle's PR (#23602) in the meantime. I agree it would be good to get consensus on renaming files soon: #20470.

[yin1999]

Hi @bsmth, we may close this issue as we have merged #20470.

I'm also going to close the fixing PR.

[bsmth]

Thanks @yin1999 - I've updated the issue description with the related PRs.