-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with "CSS Functional Notation": links in the index lead to nowhere #2432
Comments
Some of these pages do exist and the links work: some and perhaps even all of the
Others, like (Also, it seems weird that some of these are under the root and some are under a CSS property page. We should perhaps consider whether CSS function pages should all live in the same place, either directly under Web/CSS (which is the convention in our CSS docs, although I don't think it should be) or maybe even under this css_functions page. But that's a different thing and would take more careful thought.) |
I'll take a look at this. |
I'm just looking through this and am going to tidy up that page and bring it into line with other overview pages I've worked on. I think in terms of where these functions live in our docs, it makes sense for CSS-wide functions to live directly under CSS and for things which only relate to one data type (for example the transform-function) values to stay as a subpage of that data type. Which essentially means that those things defined in the Values and Units spec, stay under CSS. I think that is pretty much how things are now anyway. There are a few breaking the rule, for example As for the missing docs, I think some of these may not have browser support yet which is probably why they are not documented. Not sure what we want to do in that case. I could add a short page for each which we could flesh out with examples once they do have support. I'll raise separate issues for things which do need creating, for example the cc: @chrisdavidmills |
All sounds reasonable to me, @rachelandrew . I do wonder whether it is worth defining pages for all functions. For example, Then again, that page is very long...what do you think about that case? |
I think in terms of being able to easily link to these things, and to be able to describe them properly there is a benefit in them having their own page. Otherwise, as you say, the pages get very long. If In general the functional notations do stuff, which is why they are functions, and so having somewhere to explain the subtleties seems useful. |
Found a case where data type specific values are under CSS - https://developer.mozilla.org/en-US/docs/Web/CSS/gradient To bring this into line with filter-function and transform-function values, the gradient values (linear-gradient) etc. should relaly be under gradient. |
I agree with your reasoning here, and am happy for you to update the pages as needed. |
@chrisdavidmills I've just opened a PR with the work I did yesterday on that Functions page, plus a whole bunch of issues which have shown up above. Would appreciate opinions on #2852 |
I believe that given the changes that were made in multiple PRs relevant to this, we can consider it resolved. There are still some links to pages that haven’t actually been written yet — but those now clearly show up in red with a squiggly underline. There’s otherwise nothing unique about this page having links to other pages that don’t exist yet — we have many other pages with such links. And I don’t think we want to raise an issue for every single page we have that links to other pages which don’t exist yet — and we would not want to keep issues open indefinitely for such cases. So I’m going ahead and closing this for now. If anyone disagrees — if this case of has-links-to-yet-unwritten-pages is a special case that merits keeping an issue open for it — then please go ahead and re-open it. |
MDN URL: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Functions
What information was incorrect, unhelpful, or incomplete?
The links listed in the index lead to nowhere,
Specific section or headline?
Section, the index.
What did you expect to see?
Information regarding the selected CSS function.
Did you test this? If so, how?
Tried several links, it always returns
Sorry, the page /en-US/docs/Web/CSS/<CSS function> could not be found.
. Given the lack of results from the search, I assume that this content is removed or moved to relevant pages.MDN Content page report details
en-us/web/css/css_functions
The text was updated successfully, but these errors were encountered: