Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "in this module" from Learn #24467

Closed
10 tasks done
wbamberg opened this issue Feb 15, 2023 · 3 comments
Closed
10 tasks done

Drop "in this module" from Learn #24467

wbamberg opened this issue Feb 15, 2023 · 3 comments
Labels
Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:CSS Learning area CSS docs Content:Learn:Forms Learning area Forms docs Content:Learn:HTML Learning area HTML docs Content:Learn:JavaScript Learning area JavaScript docs Content:Learn Learning area docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@wbamberg
Copy link
Collaborator

wbamberg commented Feb 15, 2023 •
edited
Loading

I proposed this in https://github.com/orgs/mdn/discussions/328: many people are +1 and noone is against. So let's do it.

This means removing the entire "In this module" section from the Learn docs (for example: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/Events#in_this_module).

Since there are a few hundred pages, it would be good to do the work in a few PRs, maybe one for each section of Learn:
@github-actions github-actions bot added Content:Learn Learning area docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:CSS Learning area CSS docs Content:Learn:Forms Learning area Forms docs Content:Learn:HTML Learning area HTML docs Content:Learn:JavaScript Learning area JavaScript docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 15, 2023
This was referenced Feb 15, 2023
Merged
Merged
Merged
@awxiaoxian2020 awxiaoxian2020 mentioned this issue Feb 16, 2023
Closed
9 tasks
@dawei-wang
Copy link
Contributor

It seems that the "in this module section" was not included in any MathML page when they were written.

@dawei-wang dawei-wang mentioned this issue Feb 16, 2023
Merged
@Graywolf9
Copy link
Contributor

Thank you so much! If it is already in the sidebar I agree totally

This was referenced Feb 16, 2023
Merged
Merged
@drybalka drybalka mentioned this issue Feb 17, 2023
Merged
@SnowMarble SnowMarble mentioned this issue Feb 17, 2023
Closed
7 tasks
This was referenced Feb 19, 2023
Merged
Merged
@wbamberg
Copy link
Collaborator Author

Thanks for all your work on this @dawei-wang ! And thanks @drybalka for your CSS PR and originally motivating this change!

@ghost ghost mentioned this issue Mar 15, 2023
Closed
@leon-win leon-win mentioned this issue Nov 24, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:CSS Learning area CSS docs Content:Learn:Forms Learning area Forms docs Content:Learn:HTML Learning area HTML docs Content:Learn:JavaScript Learning area JavaScript docs Content:Learn Learning area docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbamberg @dawei-wang @Graywolf9