Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <p> instead of <ul> for form sections #35917

Closed
Boodac opened this issue Sep 17, 2024 · 3 comments · Fixed by #36013
Closed

Use <p> instead of <ul> for form sections #35917

Boodac opened this issue Sep 17, 2024 · 3 comments · Fixed by #36013
Labels
Content:Learn:Forms Learning area Forms docs good first issue A good issue for newcomers to get started with.

Comments

@Boodac
Copy link

Boodac commented Sep 17, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/Forms/Your_first_form

What specific section or headline is this issue about?

The <label>, <input>, and <textarea> elements

What information was incorrect, unhelpful, or incomplete?

The HTML snippet for using the first form doesn't make use of modern HTML form tags.

What did you expect to see?

Instead of organizing the form as an unordered list, I expected to see some use of things like fieldset, legend, optgroup, et cetera.

Previous education has led me to understand that forms are not unordered lists, and there are semantic/accessibility issues with the current tutorial.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@Boodac Boodac added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Sep 17, 2024
@github-actions github-actions bot added the Content:Learn:Forms Learning area Forms docs label Sep 17, 2024
@Josh-Cena
Copy link
Member

@estelle what say you?

@estelle
Copy link
Member

estelle commented Sep 18, 2024

We can change the list to four paragraphs, but we shouldn't add additional features to this page. Those are covered in later tutorials in the series.

@Boodac
Copy link
Author

Boodac commented Sep 18, 2024

@estelle This seems like the best of both worlds strategy, to use some other block level delineation to format the form. Don't want to undo all the previous "use semantic tags whenever possible" learning.

The next tutorial is careful to use things like UL to organize unordered lists of options (example: radio buttons), which seems far more semantic than using a UL for the entire form. Had no problems with the later HTML 5 parts, they're well done.

@Josh-Cena Josh-Cena added good first issue A good issue for newcomers to get started with. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 23, 2024
@Josh-Cena Josh-Cena changed the title Improvements to "your first form" Use <p> instead of <ul> for form sections Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Forms Learning area Forms docs good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants