Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading instruction #38204

Open
devoxyz opened this issue Feb 18, 2025 · 3 comments · May be fixed by #38265
Open

Misleading instruction #38204

devoxyz opened this issue Feb 18, 2025 · 3 comments · May be fixed by #38265
Labels
Content:WebExt WebExtensions docs good first issue A good issue for newcomers to get started with.

Comments

@devoxyz
Copy link

devoxyz commented Feb 18, 2025

MDN URL

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests#windows

What information was incorrect, unhelpful, or incomplete?

" In all the examples, <name> is the value of the name property in the manifest." is misleading making people thing the manifest in question is the extension manifest (manifest.json) while it should ben the name value from the native messaging manifest (mywebextension.json)

What did you expect to see?

" In all the examples, <name> is the value of the name property in the native messaging manifest."

Do you have any supporting links, references, or citations?

https://discourse.mozilla.org/t/cant-get-native-messaging-example-to-work-attempt-to-postmessage-on-disconnected-port/121764

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@devoxyz devoxyz added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 18, 2025
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Feb 18, 2025
@Josh-Cena Josh-Cena added good first issue A good issue for newcomers to get started with. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 18, 2025
@digvijayabhishikth
Copy link

Hi Can I work on this.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 21, 2025

@digvijayabhishikth Sure. The way this works is you create a PR and in the description you write the line below to create an association back to this issue. Then others will see someone is working on it.

Fixes #38204

@digvijayabhishikth digvijayabhishikth linked a pull request Feb 21, 2025 that will close this issue
@digvijayabhishikth
Copy link

Hi @hamishwillee Thank you for your prompt response. I created a PR #32865. Does this work accordingly or is there still a gap from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants