Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with grid: (min-width: 63.9385em) #9612

Closed
h9lk opened this issue Oct 6, 2021 · 3 comments
Closed

Issue with grid: (min-width: 63.9385em) #9612

h9lk opened this issue Oct 6, 2021 · 3 comments
Labels
closed: duplicate This issue or pull request already exists

Comments

@h9lk
Copy link

h9lk commented Oct 6, 2021

MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array

What information was incorrect, unhelpful, or incomplete?

This's problem with svg icons. As far as understand, this problem occurs wherever there are long names, but did not check it.

Specific section or headline?

<nav id="sidebar-quicklinks" class="sidebar"></nav>

and css rule

@media (min-width: 63.9385em)
.page-wrapper.document-page {
    grid-template-columns: minmax(25%,75%) minmax(75%,25%);
    grid-template-rows: repeat(3,auto) -webkit-max-content 1fr;
    grid-template-rows: repeat(3,auto) max-content 1fr;
}

What did you expect to see?

1

Did you test this? If so, how?

made changes in css grid percentage ratio and think this is correct

For:

<div class="page-wrapper document-page"></div>

Css:

@media (min-width: 63.9385em)
.page-wrapper.document-page {
    grid-template-columns: minmax(35%, 65%) minmax(65%, 35%);
}

or

@media (min-width: 63.9385em)
.page-wrapper.document-page {
    grid-template-columns: 35% 65%;
}
MDN Content page report details
@himanshugarg
Copy link
Contributor

Thanks @h9lk for reporting the issue. Is it similar to mdn/yari#4635 ? Would you like to include a before screenshot as well, as it the issue is not obvious to me and it shows fine(or does it?) on my Firefox browser on Windows 10:-
image

@h9lk
Copy link
Author

h9lk commented Oct 11, 2021

Thanks @h9lk for reporting the issue. Is it similar to mdn/yari#4635 ? Would you like to include a before screenshot as well, as it the issue is not obvious to me and it shows fine(or does it?) on my Firefox browser on Windows 10:- image

@himanshugarg description of mdn/yari#4635 problem, as well as way to solve it - very lame, but they are similar. Tested it with google chrome browser in last build, of course i can attach a screenshot
1

Opera same
2

@ddbeck ddbeck added the closed: duplicate This issue or pull request already exists label Oct 22, 2021
@ddbeck
Copy link
Contributor

ddbeck commented Oct 22, 2021

I've mentioned this issue on mdn/yari#4635. Since this isn't a content issue, I'll close this one as a duplicate. Thank you for reporting this!

@ddbeck ddbeck closed this as completed Oct 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants