Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 28841 font synthesis position #691

Merged
merged 7 commits into from
Sep 26, 2023

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Sep 13, 2023

Description

  • Added the font-synthesis-position property
  • Updated the font-synthesis shorthand property to include the position value

Motivation

Working on the documentation for [CSS] Add font-synthesis-position property

Additional details

https://drafts.csswg.org/css-fonts-4/#font-synthesis-position

Related issues and pull requests

@OnkarRuikar
Copy link
Contributor

@dletorey or reviewer, please rename the the PR to feat: 28841 font synthesis position. For more information refer this discussion.

@dletorey dletorey changed the title 28841 font synthesis position feat: 28841 font synthesis position Sep 14, 2023
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @dletorey; just one small nit to potentially fix, but I'm approving so as not to hold you up.

css/properties.json Outdated Show resolved Hide resolved
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wbamberg wbamberg merged commit 5ced75f into mdn:main Sep 26, 2023
3 checks passed
@github-actions
Copy link
Contributor

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

teoli2003 pushed a commit that referenced this pull request Nov 3, 2023
🤖 I have created a release *beep* *boop*
---


## [2.2.0](v2.1.0...v2.2.0)
(2023-11-03)


### Features

* 28841 font synthesis position
([#691](#691))
([5ced75f](5ced75f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey dletorey deleted the 28841-font-synthesis-position branch April 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants