fix(css): replace value 'center' with '0% 0%' for mask-position inital value #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
bsmth
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Thank you!
(see https://www.w3.org/TR/css-masking-1/#the-mask-position)
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
bsmth
pushed a commit
that referenced
this pull request
Feb 23, 2024
🤖 I have created a release *beep* *boop* --- ## [2.4.1](v2.4.0...v2.4.1) (2024-02-22) ### Bug Fixes * **css:** replace value 'center' with '0% 0%' for mask-position inital value ([#714](#714)) ([2987ea9](2987ea9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l value
Description
The page says that the mask-position Initial value is center, but when I tested it in Chrome, Firefox, etc., it was not center.
So I changed the initial value of the mask-position property from center to 0% 0%.
Motivation
It will be helpful for people working with CSS by referring to the mdn document.
Additional details
#713
https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position
Related issues and pull requests