Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): remove non-supported caption-side values #818

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 3, 2024

Description

per bcd and mdn doc, these logical values havn't been supported by any platform

Motivation

Additional details

https://developer.mozilla.org/en-US/docs/Web/CSS/caption-side

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 3, 2024 12:49
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 3, 2024 12:49
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 3, 2024 12:49
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch! Thank you :)

@pepelsbey pepelsbey merged commit f0b8774 into mdn:main Dec 5, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the caption-side branch December 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants