Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish HTML element examples #999

Closed
wbamberg opened this issue Jun 26, 2018 · 9 comments
Closed

Finish HTML element examples #999

wbamberg opened this issue Jun 26, 2018 · 9 comments
Assignees

Comments

@wbamberg
Copy link
Contributor

There are still 7 HTML elements missing an example:

<h1>-<h6>
<link>
<style>
<a>
<bdi>
<bdo>
<figure>

Acceptance criteria

All HTML elements have interactive examples, except those we have explicitly marked as not suitable for examples.

@wbamberg wbamberg added this to the Sprint 1 Q3 2018 milestone Jun 26, 2018
@jmswisher jmswisher removed this from the Sprint 1 Q3 2018 milestone Jun 29, 2018
@stephanmax
Copy link
Contributor

Uhhh, finishing things! That would play nicely with my mild OCD ;)
Happy to take this one.

@wbamberg
Copy link
Contributor Author

wbamberg commented Jul 4, 2018

Sounds great @stephanmax . It would probably be good to have separate issues for each example, so more than one person can contribute examples. There are already issues for four of these examples, some of which have been started:

  • <bdo> - this is currently unassigned, although @Elchi3 started a PR for it, but it needs rework before it can be merged.

  • <bdi> - same story as for <bdo>.

  • <link> - currently unassigned, some discussion in the bug but no PR.

  • <h1>–<h6> - currently unassigned, a PR filed with some outstanding review comments.

I think it would be fine to take any of the above, and either reuse any existing work or start again from scratch.

For the others:

@chrisdavidmills
Copy link
Contributor

<bdi> and <bdo> examples done: #1041

@chrisdavidmills
Copy link
Contributor

<link> example also done: #1029

@stephanmax
Copy link
Contributor

Cool, that only leaves <h*>, I think. I know there is a PR and I wasn't sure what the usual process is for those scenarios, but I am happy to jump in and finish that example.

@chrisdavidmills
Copy link
Contributor

@stephanmax if you'd be willing to jump in and finish off the h1-h6 example, that would be much appreciated! Feel free to put me as a reviewer once you're done. Sheppy was working on it, but he has been pulled on to other things now.

In that case, I can move on to the HTML global attribute live examples.

@chrisdavidmills
Copy link
Contributor

Oh, and just for the record, we also have an example in for <a>: #1022

(Thanks again @stephanmax !)

@stephanmax
Copy link
Contributor

My pleasure, @chrisdavidmills. Will get the <h*> example in.

@jmswisher
Copy link

Heading elements example is done and in-page

@mfuji09 mfuji09 mentioned this issue May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants