Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool sync-translated-content formats frontmatter strings with single quote differently than prettier #108

Closed
caugner opened this issue Jan 28, 2025 · 1 comment
Closed

tool sync-translated-content formats frontmatter strings with single quote differently than prettier #108

caugner opened this issue Jan 28, 2025 · 1 comment
Labels
waiting for release

Comments

@caugner
Copy link
Contributor

caugner commented Jan 28, 2025 •
edited
Loading

What information was incorrect, unhelpful, or incomplete?

The sync-translated-content command updates the frontmatter as follows:

-title: "Évaluation: dépannage d'accessibilité"
+title: 'Évaluation: dépannage d''accessibilité'

What did you expect to see?

Either markdown-lint or the frontmatter linter in content expect this:

title: "Évaluation: dépannage d'accessibilité"

This seems in fact more readable than the syntactically correct alternative that rari writes:

title: 'Évaluation: dépannage d''accessibilité'

Do you have any supporting links, references, or citations?

This currently affects the French sync-translated-content PR:

Do you have anything more you want to share?

No response
@caugner caugner added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 28, 2025
@fiji-flo fiji-flo added waiting for release and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 29, 2025
@fiji-flo
Copy link
Contributor

fixed in #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caugner @fiji-flo