Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted macros #4579

Closed
6 tasks done
escattone opened this issue Mar 18, 2021 · 11 comments · Fixed by #10724
Closed
6 tasks done

Remove unwanted macros #4579

escattone opened this issue Mar 18, 2021 · 11 comments · Fixed by #10724
Labels
l10n-ru Issues related to Russian content.

Comments

@escattone
Copy link
Contributor

escattone commented Mar 18, 2021

We'd like to remove the following macros from all documents (English, non-English, and archived):

@escattone escattone added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 18, 2021
@escattone escattone changed the title Remove unwanted Kumascript macros Remove unwanted macros Mar 18, 2021
@Rumyra Rumyra added enhancement Improves an existing feature. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 8, 2021
@himanshugarg
Copy link

himanshugarg commented Sep 7, 2021

These reported macros no longer appear in en-US content:-

~/content$ grep -rw fx_minversion_header 
~/content$ grep -rw fx_minversion_inline
~/content$ grep -rw gecko_minversion_header
node_modules/@mdn/yari/kumascript/src/info.js:  "gecko_minversion_header",
~/content$ grep -rw gecko_minversion_inline
node_modules/@mdn/yari/kumascript/src/info.js:  "gecko_minversion_inline",
~/content$ grep -rw IncludeSubnav
node_modules/@mdn/yari/content/translation.js:    "IncludeSubnav",
node_modules/@mdn/yari/kumascript/macros/IncludeSubnav.ejs:// The IncludeSubnav macro is considered deprecated.
node_modules/@mdn/yari/kumascript/index.js:  'The following documents form a circular dependency when rendering (via the "page" and/or "IncludeSubnav" macros):';
~/content$ grep -r "{languages("
~/content$ 

@wbamberg
Copy link
Contributor

This is done for mdn/content, apparently, but there are lots in mdn/translated-content still. @ddbeck , can you transfer this issue there?

@sideshowbarker sideshowbarker transferred this issue from mdn/content Mar 13, 2022
@SphinxKnight SphinxKnight added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Mar 15, 2022
@SphinxKnight
Copy link
Member

SphinxKnight commented Mar 15, 2022

Tagging all active locales "for reach", if macros are already absent from any, please let me know so that I can remove the right tags.
Edit: l10n-fr to be dealt with under #4593

@SphinxKnight SphinxKnight removed the l10n-fr Issues related to French content. label Mar 15, 2022
@yin1999
Copy link
Member

yin1999 commented Mar 22, 2022

@SphinxKnight removed all those macros in l10n-zh via #4728 #4729

@cw118 cw118 removed enhancement Improves an existing feature. l10n-zh Issues related to Chinese content. labels Mar 22, 2022
@todomagichere
Copy link
Contributor

@JuanVqz @Graywolf9 Once my last PR will be approved i guess i can take on this issue. The total files with one or more macros on it are 193, and the macros to remove in all files are 290.

@JuanVqz
Copy link
Member

JuanVqz commented Jun 28, 2022

The total files with one or more macros on it are 193, and the macros to remove in all files are 290.

@todomagichere I did create a new issue to track all the removed macros, could you please add more info there? Thanks!
#6554

@Graywolf9
Copy link
Contributor

Thank you so much @escattone I note that languages is already tracked here #5603 just for avoid duplicity

@SphinxKnight
Copy link
Member

Tbh, #5603 arrived later than this one (2021 ;))

@queengooborg queengooborg added this to the Macros removal milestone Aug 9, 2022
@mfuji09
Copy link
Collaborator

mfuji09 commented Aug 25, 2022

The all macros have been removed in the ja locale.

@yin1999
Copy link
Member

yin1999 commented Aug 30, 2022

Done for ko in #8096.

@yin1999 yin1999 removed the l10n-ko Issues related to Korean content. label Aug 30, 2022
@Graywolf9
Copy link
Contributor

Graywolf9 commented Nov 15, 2022

I think this is done in es

doing:

rg -i "\{\{\s?(fx_minversion_header|fx_minversion_inline|gecko_minversion_header|gecko_minversion_inline|IncludeSubnav|languages)"

throws 0 results

@yin1999 yin1999 removed the l10n-es Issues related to Spanish content. label Nov 15, 2022
@yin1999 yin1999 removed the l10n-pt-br Issues related to Brazilian Portuguese label Nov 19, 2022
@sashasushko sashasushko moved this to Done in MDN Localization Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ru Issues related to Russian content.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.