feat(language-menu): add "Remember language" experiment #11518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless the user manually switched the locale for the current page.
caugner
changed the title
github-actions
bot
added
redirects
LeoMcA
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Code looks good, but I'm torn on the overall behaviour:
Obviously the current behaviour is an annoyance to many users, since we've received a number of reports about it, but a fix which results in pasting a link containing e.g. the fr locale in and being redirected to en-US because of prior behaviour feels wrong.
However, I don't see an elegant way to do this in some cases but not others, so this feels like the best approach for most people. Let's see if we get an influx of issues filed saying they want something like the old behaviour back.
I imagine most users who need to switch between locales a lot are in our close community (eng/content/l10n), and perhaps we should let them know ahead of time that setting the cookie to something like false will disable this behaviour - perhaps we should explicitly support that, and leave it untouched when using the dropdown menu in this case - that can be a follow up task/PR though.
I realize that this could indeed be an annoyance for us, when looking at issues, and for translators.
I agree that we should support opt-out from this feature, maybe even via the UI from the locale dropdown. |
|
fwiw I filled #11717 |
This makes the Switch appear as big as surrounding text.
caugner
changed the title
caugner
force-pushed
the
MP-1242-redirect-to-preferred-locale
branch
from
d539049
to
a3be882
Compare
3 tasks
caugner
changed the title
LeoMcA
approved these changes
Sep 20, 2024
client/src/ui/organisms/article-actions/language-menu/index.scss
Outdated
Show resolved
Hide resolved
client/src/ui/organisms/article-actions/language-menu/index.tsx
Outdated
Show resolved
Hide resolved
client/src/ui/organisms/article-actions/language-menu/index.tsx
Outdated
Show resolved
Hide resolved
client/src/ui/organisms/article-actions/language-menu/index.tsx
Outdated
Show resolved
Hide resolved
client/src/ui/organisms/article-actions/language-menu/index.tsx
Outdated
Show resolved
Hide resolved
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Co-authored-by: Leo McArdle <leo@mca.is>
caugner
force-pushed
the
MP-1242-redirect-to-preferred-locale
branch
from
2006375
to
5bcbea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1242)
Fixes #275.
Fixes #2528.
Fixes #2724.
Fixes #6981.
Problem
en-USif a page is not available in a locale (including the MDN Curriculum and the MDN Blog), but this means the user has to manually navigate back to their preferred locale.Solution
Reuse the
preferredlocalecookie that we previously set whenever the user switched the locale in the user interface, but:Caveat: Changing the locale directly in the address bar will still redirect back to the "remembered" language.
How did you test this change?
Ran
npm startin/cloud-function, then tested locally withxh: