chore(ai-help): use index.json instead of plain.html for embedding sources #12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n instead of plainhtml
argl
changed the title
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Let's deploy this to stage, so that @mirunacurtean can check AI Help for regressions.
|
@mirunacurtean this is already on staging |
|
@caugner Only saw this today, but I did start doing a check. I see where on a deadline with rari beta as it will be released today. is this part of it? And what should I do a quick sanity check of? So far I have:
When it comes to giving an answer I noticed an older issue, where AI Help starts producing the consulted content list and then it gives a "I'm sorry, but I can't answer questions outside web development." response. This also occurs on production, so it's not a regression. Although maybe it might be happening more with questions, for example "How can you retry or fallback to alternative external APIs in case of failures?" still gets a comprehensive response in prod but not in stage.
|
caugner
changed the title
caugner
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use index.json instead of plain.html for generating text sources for embedding
(MP-1743)
Problem
rari/yari parity
Solution
Added a new code path to assemble an interim html document directly form the json data. The old behaviour is still available behind a flag:
--use-plain-html.How did you test this change?
Locally, tried a few documents and diffed the text corpus output beween old and new behaviour.