Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i10n): localize secureContext header and inline text in ko #12183

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

ohprettyhak
Copy link
Contributor

Summary

Fixes mdn/content#37108.

Problem

SecureContext header and inline badge inside Korean document is displayed as English.

Solution

Add Korean translation of SecureContext header and inline content.


Screenshots

Before

1) header

image

2) badge

image

After

1) header

Screenshot 2024-11-25 at 11 23 50

2) badge

Screenshot 2024-11-25 at 11 24 27

How did you test this change?

Run yari locally by following the instructions in README.md.

@ohprettyhak ohprettyhak requested a review from a team as a code owner November 26, 2024 10:24
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 26, 2024
@caugner caugner requested review from a team and sunhpark42 and removed request for a team December 2, 2024 09:03
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, be aware that this is handled differently in rari (by using JSON files for these translations in the content repo) and needs a PR over there as well to get us through the transition period.

@argl argl merged commit 3e781a0 into mdn:main Dec 6, 2024
13 checks passed
@ohprettyhak ohprettyhak deleted the fix/ko/secure-context branch December 6, 2024 14:19
@ohprettyhak
Copy link
Contributor Author

I have updated the JSON file corresponding to the rari system and created a PR (mdn/content#37111). :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ko] Update kumascript related to secureContext
2 participants