Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): add hreflang to alternate rss link #8756

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 4, 2023

Summary

Problem

#8742 added a <link rel="alternate" /> for the Blog's RSS feed, but:

  1. It omits the hreflang attribute, even though it's also added on translated pages. (MP-384)
  2. The test expectations have not been updated. (MP-383)

Solution

Add the hreflang attribute and update the test expectations.


How did you test this change?

🟢 Tests are passing on this PR.

@caugner caugner requested review from LeoMcA and fiji-flo May 4, 2023 12:20
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌐 👍

@fiji-flo fiji-flo merged commit f71415e into main May 4, 2023
@fiji-flo fiji-flo deleted the fix-alternate-rss-link branch May 4, 2023 12:30
captainbrosset pushed a commit to captainbrosset/yari that referenced this pull request May 4, 2023
* fix(ssr): add hreflang to rss link

* test(ssr): update alternate test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants