Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): support running in git submodule #9578

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Aug 29, 2023

also add some jsdoc type hinting

Trying to commit locally I was getting this error:

Oops! Something went wrong! :(

ESLint: 8.48.0

Error: Cannot read config file: /workspace/yari/.eslintrc.cjs
Error: ENOTDIR: not a directory, lstat '/workspace/yari/.git/info/exclude'

I've been running yari from a git submodule as an easier way of transferring my dev environment state between devices. I'm not sure it's a setup we want to explicitly support, but it should fail more gracefully than an error message and no commit.

also add some jsdoc type hinting
@LeoMcA LeoMcA requested a review from fiji-flo August 29, 2023 16:15
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

.eslintrc.cjs Outdated Show resolved Hide resolved
@LeoMcA LeoMcA merged commit c40fb92 into main Sep 1, 2023
@LeoMcA LeoMcA deleted the eslintrc-submodule branch September 1, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants