Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve failed exemplar messaging #5

Open
DataStrategist opened this issue Dec 2, 2022 · 0 comments
Open

Improve failed exemplar messaging #5

DataStrategist opened this issue Dec 2, 2022 · 0 comments

Comments

@DataStrategist
Copy link
Contributor

Hi! Me again :)

I'm going to be wrapping the outputs of failed expectations in better prose (so that min(data[["opponent_amount"]], na.rm = TRUE) > 0 is not TRUE becomes opponent_amount should be positive, but isn't or some such.

If you want, I can make these expectations directly in the package and PR it if you're interested?

Also happy to discuss how the errors should be reported:

  • opponent_amount should be positive, but isn't
  • Expected opponent_amount to be positive
  • opponent_amount shouldn't be negative

etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant