Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyHyp doesn't work with numpy 1.24 #69

Closed
A-CGray opened this issue Jan 23, 2023 · 3 comments · Fixed by #73
Closed

pyHyp doesn't work with numpy 1.24 #69

A-CGray opened this issue Jan 23, 2023 · 3 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@A-CGray
Copy link
Member

A-CGray commented Jan 23, 2023

Description

Self explanatory. We are trying to update the "latest" docker images to numpy 1.24 (https://github.com/mdolab/docker/pull/208) and getting the error below in all the pyHyp tests. This error looks pretty much identical to mdolab/adflow#256 so the solution will likely also be similar

Steps to reproduce issue

  1. Install numpy v1.24
  2. Run pyHyp tests

Current behavior

2023-01-17T17:05:27.9879234Z (mpi) ./test_all_examples.py:TestExamples.test_sphere ... FAIL (00:00:0.94, 315 MB)
2023-01-17T17:05:27.9880090Z Traceback (most recent call last):
2023-01-17T17:05:27.9881809Z   File "/home/***/.pyenv/versions/3.10.9/lib/python3.10/site-packages/testflo/test.py", line 418, in _try_call
2023-01-17T17:05:27.9886788Z     func()
2023-01-17T17:05:27.9887811Z   File "/home/***/repos/pyhyp/tests/./test_all_examples.py", line 98, in test_sphere
2023-01-17T17:05:27.9888961Z     from examples.sphere.runSphere import volumeFile, commonOptions
2023-01-17T17:05:27.9889972Z   File "/home/***/repos/pyhyp/tests/../examples/sphere/runSphere.py", line 55, in <module>
2023-01-17T17:05:27.9891336Z     hyp = pyHypMulti(options=options, commonOptions=commonOptions, skipList=skipList)
2023-01-17T17:05:27.9892759Z   File "/home/***/repos/pyhyp/tests/../pyhyp/pyHyp.py", line 225, in __init__
2023-01-17T17:05:27.9893807Z     hypGrid = pyHyp(comm, options, debug)
2023-01-17T17:05:27.9895165Z   File "/home/***/repos/pyhyp/tests/../pyhyp/pyHyp.py", line 424, in __init__
2023-01-17T17:05:27.9895976Z     self._setOptions()
2023-01-17T17:05:27.9896977Z   File "/home/***/repos/pyhyp/tests/../pyhyp/pyHyp.py", line 763, in _setOptions
2023-01-17T17:05:27.9898101Z     self.hyp.hypinput.sourcestrengthfile = self._expandString("")
2023-01-17T17:05:27.9899552Z ValueError: 0-th dimension must be 512 but got 0 (not defined).

Expected behavior

All tests pass

@A-CGray A-CGray added the bug Something isn't working label Jan 23, 2023
@sseraj
Copy link
Collaborator

sseraj commented Feb 17, 2023

pyHyp works with numpy up to 1.23. See mdolab/adflow#256 for discussion on updating to 1.24.

@anilyil
Copy link
Contributor

anilyil commented Mar 10, 2023

Do we need to fix this issue same way we addressed mdolab/adflow#256 ?

@eirikurj
Copy link
Contributor

The issue described here (and in mdolab/adflow#256) should be resolved when 1.24.3 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants