Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a badge on the extension icon #130

Closed
mdolr opened this issue Oct 14, 2020 · 1 comment · Fixed by #133
Closed

Add a badge on the extension icon #130

mdolr opened this issue Oct 14, 2020 · 1 comment · Fixed by #133
Assignees
@katyasichov
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 14, 2020

To make it more clear whether the extension is enabled or not, and to show people that the icon is click-able, a badge should be added. It should display ON/OFF depending on the state of the extension on the page.

Just like Adblock plus or Ublock use a badge to display the amount of ads blocked on a page
@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 14, 2020
@katyasichov
Copy link
Contributor

Hey, I would like to try it out!

@katyasichov katyasichov mentioned this issue Oct 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katyasichov katyasichov

Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added badge to extension icon katyasichov/survol
2 participants
@mdolr @katyasichov