Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derivative (L) matrix should have a square basis #10

Closed
jjstickel opened this issue Dec 3, 2021 · 2 comments
Closed

derivative (L) matrix should have a square basis #10

jjstickel opened this issue Dec 3, 2021 · 2 comments

Comments

@jjstickel
Copy link
Contributor

It seems to me that the derivative L matrix should be square (mxm where m is the number of columns of A) for order 0 (i.e., square identity matrix) and decreasing rows for higher orders, rather than the shape of A. At least, that is what is needed for my data-smoothing application. I have made the necessary changes here:

jjstickel@604f359

Does this seem reasonable? Or are there cases when L should correspond to both dimensions of A? All the existing tests pass, but from what I can tell, they all use a square A. I'll make a PR later after I have worked out additional code I might want to add.

@mdpetters
Copy link
Owner

Thanks for the comment. After some testing with a non-square system I agree that L matrix should be square. In fact, the way it is implemented in the current version, L'L is missing terms in the last rows/columns, which leads to a corresponding lack or regularization at the edge of the domain. The changes mentioned above fix this, and thus also improve the package. A PR would be very welcome.

@jjstickel
Copy link
Contributor Author

Great, thanks for looking at this. I'll submit a PR in the next few days. Still working on some other concepts that may go in this PR or in a second one at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants