feat: configurable query for site URL #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdreizin
requested changes
Jan 26, 2019
mdreizin
approved these changes
Jan 26, 2019
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@amclin Have you had a chance to test 1.4.0 version? |
|
Just tested in our project with 1.4.0. Working as intended. Thanks for the fast response and merge @mdreizin ! |
|
@amclin Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core Gatsby sitemap plugin allows for Configurable queries to get the siteUrl. See: https://www.gatsbyjs.org/packages/gatsby-plugin-sitemap
This is necessary because when using Gatsby to generate sites with dynamic URLs, you can't dynamically set the siteMetadata from a data source.
This PR adds the same capability to the robots.txt plugin so that it can behave consistently. If sitemap.xml is using a different domain, then robots.txt should be able to as well.